madb Issue Tracker Rss Feed

Closed Issue: Issues w/ BusyBox.cs/ProcessNewLines() [16000]

camalot — Thu, 16 May 2013 09:06:50 GMT

There is an issue with ProcessNewLines in your BusyBox detection code. The section that checks what functions are available gets executed on every line, which causes the library to crash with some devices. I modified your code to implement a finite state machine, so that it would first find the version number...then look for "defined functions"...then process the functions immediately afterwards. This fixed the issue.

[EDIT] Bah...CodePlex removed my formatting. Attaching as a file.

Closed Issue: Bug w/ MountPointReceiver.cs/ProcessNewLines() [16001]

camalot — Thu, 16 May 2013 09:06:50 GMT

On certain devices (like the Coby Kyros), there can be multiple volumes mounted on the same mount path. Not sure exactly how that works...but the current code crashes when trying to add "/" a second time (see below):

rootfs on / type rootfs (rw)
ubi0:rootfs on / type ubifs (rw,relatime)

As a temporary workaround, wrapping the "Device.MountPoints.Add(name, mnt)" line with a conditional check to see if the mountpoint already exists in the list will correct this:

if (!Device.MountPoints.ContainsKey(name)) {
Device.MountPoints.Add(name, mnt);
}

Closed Issue: Issues with CanSU( ) [16822]

camalot — Thu, 16 May 2013 09:06:50 GMT

public bool CanSU( ) in Device.cs tries to ascertain if SU commands can be run by executing 'su -c echo' command. However, it passes a NullOutputReceiver.Instance whereby the shell output is lost.

Plausible fixes:
1. Handle the "su: permission denied" output in public void ExecuteRemoteCommand() of AdbHelper.cs and raise an exception
2. Pass a valid output receiver and handle this scenario

Closed Issue: SyncPackageToDevice assumes root access [16823]

camalot — Thu, 16 May 2013 09:06:49 GMT

public String SyncPackageToDevice() assumes root access and tries to copy to /data/local/tmp folder (which fails later while doing chmod(0666)).
the temp directory should be the home directory perhaps.

Closed Issue: Confusing FileSystem MakeDirectory() [16825]

camalot — Thu, 16 May 2013 09:06:49 GMT

MakeDirectory() accepts a path and breaks the path string into folder segments. Thereafter it starts creating directories present in the segments array at the same level (level being the first directory that is found missing)

For example: If the Dir path is /mnt/sdcard/folder1/folder2/folder3 and on the device only the path /mnt/sdcard is present, the MakeDirectory() creates 3 new folders:
/mnt/sdcard/folder1
/mnt/sdcard/folder2
/mnt/sdcard/folder3

Fix (?):
Add the line :
current = FileEntry.FindOrCreate(Device, LinuxPath.Combine(current.FullPath, pathItem));

Such that
if ( !found ) {
Device.ExecuteShellCommand ( "mkdir {0}", cer, LinuxPath.Combine ( current.FullPath, pathItem ) );
current = FileEntry.FindOrCreate(Device, LinuxPath.Combine(current.FullPath, pathItem))
}

Closed Task: RawImage Byte Order Out Of Order BugFix [18216]

camalot — Thu, 16 May 2013 09:06:48 GMT

We made the following fix in our project, the colors in Nexus are coming correctly now.

On the GetFrameBuffer method of the AdbHelper we added the following part.
try
{
if (version == 1)
{
for (int i = 0; i < reply.Length; i += 4)
{
var temp = reply[i];
reply[i] = reply[i + 2];
reply[i + 2] = temp;
}
}
}
catch
{
}
imageParams.Data = reply;

Edited Issue: FileSystem ResolveLink to be completed [19712]

camalot — Wed, 15 May 2013 12:09:48 GMT

ResolveLink does not work well on symbolic links (and when busybox is not present). Manual parsing of the links might be required to support the functionality. This functionality is important for FindFileEntry to work as expected.

Edited Issue: Fix remoteFilePath in SyncPackageToDevice [19711]

camalot — Wed, 15 May 2013 12:09:20 GMT

the remoteFilePath is being constructed using localFilePath whereas, it should be using packageFilePath.

Created Issue: FileSystem ResolveLink to be completed [19712]

pingvishal — Wed, 15 May 2013 05:27:43 GMT

Created Issue: Fix remoteFilePath in SyncPackageToDevice [19711]

pingvishal — Wed, 15 May 2013 05:24:17 GMT

the remoteFilePath is being constructed using localFilePath whereas, it should be using packageFilePath.

Created Issue: Need x64 & x86 builds [18454]

camalot — Wed, 08 Aug 2012 23:26:25 GMT

since Droid Explorer uses specific binaries for its build, madbee needs to have these too.

Commented Issue: RawImage Byte Order Out Of Order BugFix [18216]

camalot — Fri, 15 Jun 2012 03:45:29 GMT

I am going to see how doing it this way affects performance. I want the screen grab to be as fast as possible. I would like to see if I can implement this using bit shifting (something that I have been toying with unsuccessfully) but if I can't, then this will go in as, at the very least, a temporary solution until I can revisit bit shifting again. Thank you for submitting this.

Created Issue: RawImage Byte Order Out Of Order BugFix [18216]

keremkusmezer — Mon, 11 Jun 2012 12:57:23 GMT

Commented Issue: Confusing FileSystem MakeDirectory() [16825]

camalot — Mon, 28 Nov 2011 20:20:17 GMT

There was a bug in logic that was did not change the "current" unless it was found. which is why it added them to the first "found" folder. On top of that, I have added a check that if busybox is on the system, it will use the mkdir from that as it supports the -p (--parents) switch which will create the tree of folders if needed.

Commented Issue: SyncPackageToDevice assumes root access [16823]

camalot — Mon, 28 Nov 2011 20:17:49 GMT

I am marking this fixed, but I am not 100% on the solution. It no longer uses /data/local/tmp for the temp directory, but not sure what issues this can cause with other devices. it is now using /sdcard/tmp

Commented Issue: Issues with CanSU( ) [16822]

camalot — Mon, 28 Nov 2011 20:16:26 GMT

This is now fixed. It checks in AdbHelper.ExecuteRemoteCommand if the permission was denied. If it is, it throws a new PermissionDeniedException. The NullOutputReceiver, where referenced, is fine in this situation because the ExecuteRemoteCommand has access to the output and it is not needed beyond the point of checking if the su exec is there and that permission is granted on using it.

Commented Issue: Confusing FileSystem MakeDirectory() [16825]

camalot — Mon, 28 Nov 2011 15:04:23 GMT

FileEntry.FindOrCreate will not create the path on the device, it creates just the FileEntry object but Exists = false. If you use just FileEntry.Find, it will throw an FileNotFoundException, where FindOrCreate lets you create the entry, even if it does not exist on disk. It is a bit like the System.IO.FileInfo object. You can create the FileInfo, even if it doesn't exist on disk. I guess what really is needed in the FileEntry is a "Create" and maybe FindOrCreate should get a new name...

Created Issue: Confusing FileSystem MakeDirectory() [16825]

pingvishal — Mon, 31 Oct 2011 11:15:21 GMT

Created Issue: SyncPackageToDevice assumes root access [16823]

pingvishal — Mon, 31 Oct 2011 07:35:22 GMT

Created Issue: Issues with CanSU( ) [16822]

pingvishal — Mon, 31 Oct 2011 06:41:41 GMT